From 00d1ffc8c85234fb8fe873d1591374289de1356d Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Wed, 29 Aug 2018 04:09:04 -0400 Subject: [PATCH] Googletest export Fix the typed test names in the tests for customized typed test parameters. As required by googletest documentation, the names should not contain an underscore. PiperOrigin-RevId: 210678652 --- googletest/include/gtest/gtest-typed-test.h | 2 +- googletest/test/googletest-output-test_.cc | 8 ++++---- googletest/test/gtest-typed-test_test.cc | 16 ++++++++-------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/googletest/include/gtest/gtest-typed-test.h b/googletest/include/gtest/gtest-typed-test.h index 29b08599..65be6998 100644 --- a/googletest/include/gtest/gtest-typed-test.h +++ b/googletest/include/gtest/gtest-typed-test.h @@ -96,7 +96,7 @@ TYPED_TEST(FooTest, HasPropertyA) { ... } // static std::string GetName(int) { // if (std::is_same()) return "char"; // if (std::is_same()) return "int"; -// if (std::is_same()) return "unsigned_int"; +// if (std::is_same()) return "unsignedInt"; // } // }; // TYPED_TEST_CASE(FooTest, MyTypes, MyTypeNames); diff --git a/googletest/test/googletest-output-test_.cc b/googletest/test/googletest-output-test_.cc index d6f7e0ba..df82517a 100644 --- a/googletest/test/googletest-output-test_.cc +++ b/googletest/test/googletest-output-test_.cc @@ -811,9 +811,9 @@ class TypedTestNames { template static std::string GetName(int i) { if (testing::internal::IsSame::value) - return std::string("char_") + ::testing::PrintToString(i); + return std::string("char") + ::testing::PrintToString(i); if (testing::internal::IsSame::value) - return std::string("int_") + ::testing::PrintToString(i); + return std::string("int") + ::testing::PrintToString(i); } }; @@ -852,10 +852,10 @@ class TypedTestPNames { template static std::string GetName(int i) { if (testing::internal::IsSame::value) { - return std::string("unsigned_char_") + ::testing::PrintToString(i); + return std::string("unsignedChar") + ::testing::PrintToString(i); } if (testing::internal::IsSame::value) { - return std::string("unsigned_int_") + ::testing::PrintToString(i); + return std::string("unsignedInt") + ::testing::PrintToString(i); } } }; diff --git a/googletest/test/gtest-typed-test_test.cc b/googletest/test/gtest-typed-test_test.cc index e9eed639..b2457301 100644 --- a/googletest/test/gtest-typed-test_test.cc +++ b/googletest/test/gtest-typed-test_test.cc @@ -174,10 +174,10 @@ class TypedTestNames { template static std::string GetName(int i) { if (testing::internal::IsSame::value) { - return std::string("char_") + ::testing::PrintToString(i); + return std::string("char") + ::testing::PrintToString(i); } if (testing::internal::IsSame::value) { - return std::string("int_") + ::testing::PrintToString(i); + return std::string("int") + ::testing::PrintToString(i); } } }; @@ -189,13 +189,13 @@ TYPED_TEST(TypedTestWithNames, TestCaseName) { EXPECT_STREQ(::testing::UnitTest::GetInstance() ->current_test_info() ->test_case_name(), - "TypedTestWithNames/char_0"); + "TypedTestWithNames/char0"); } if (testing::internal::IsSame::value) { EXPECT_STREQ(::testing::UnitTest::GetInstance() ->current_test_info() ->test_case_name(), - "TypedTestWithNames/int_1"); + "TypedTestWithNames/int1"); } } @@ -311,13 +311,13 @@ TYPED_TEST_P(TypeParametrizedTestWithNames, TestCaseName) { EXPECT_STREQ(::testing::UnitTest::GetInstance() ->current_test_info() ->test_case_name(), - "CustomName/TypeParametrizedTestWithNames/p_char_0"); + "CustomName/TypeParametrizedTestWithNames/parChar0"); } if (testing::internal::IsSame::value) { EXPECT_STREQ(::testing::UnitTest::GetInstance() ->current_test_info() ->test_case_name(), - "CustomName/TypeParametrizedTestWithNames/p_int_1"); + "CustomName/TypeParametrizedTestWithNames/parInt1"); } } @@ -328,10 +328,10 @@ class TypeParametrizedTestNames { template static std::string GetName(int i) { if (testing::internal::IsSame::value) { - return std::string("p_char_") + ::testing::PrintToString(i); + return std::string("parChar") + ::testing::PrintToString(i); } if (testing::internal::IsSame::value) { - return std::string("p_int_") + ::testing::PrintToString(i); + return std::string("parInt") + ::testing::PrintToString(i); } } };