From 40604f891efd16779af66c2b3e42f433ead74b15 Mon Sep 17 00:00:00 2001 From: vladlosev Date: Mon, 8 Mar 2010 20:42:47 +0000 Subject: [PATCH] Fixes an 'unreachable code' warning by MSVC on certain opt settings in gtest-death-test_test.cc. --- test/gtest-death-test_test.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/gtest-death-test_test.cc b/test/gtest-death-test_test.cc index c57d700f..ed5b53b7 100644 --- a/test/gtest-death-test_test.cc +++ b/test/gtest-death-test_test.cc @@ -110,7 +110,12 @@ void DieInside(const char* function) { // system call and thus safer in the presence of threads. exit() // will invoke user-defined exit-hooks, which may do dangerous // things that conflict with death tests. - _exit(1); + // + // Some compilers can recognize that _exit() never returns and issue the + // 'unreachable code' warning for code following this function, unless + // fooled by a fake condition. + if (AlwaysTrue()) + _exit(1); } // Tests that death tests work.