From f2333609337c1ce87ed14073fc4064475d2783b0 Mon Sep 17 00:00:00 2001 From: antismap Date: Thu, 21 Mar 2019 14:38:50 +0100 Subject: [PATCH 1/2] Note about INSTANTIATE_TEST_SUITE_P / INSTANTIATE_TEST_CASE_P keyword change See https://github.com/google/googletest/issues/2065 --- googletest/docs/advanced.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/googletest/docs/advanced.md b/googletest/docs/advanced.md index ea9b80fc..c2438dee 100644 --- a/googletest/docs/advanced.md +++ b/googletest/docs/advanced.md @@ -1396,6 +1396,8 @@ namespace: For more details, see the comments at the definitions of these functions. +NOTE: The `INSTANTIATE_TEST_SUITE_P` keyword is only valid since 1.8.1. For previous releases the keyword is `INSTANTIATE_TEST_CASE_P`. More generally, please refer to the documentation matching your release version. + The following statement will instantiate tests from the `FooTest` test suite each with parameter values `"meeny"`, `"miny"`, and `"moe"`. From d31151a4932c85d735feb6c6e7159ca4d91008da Mon Sep 17 00:00:00 2001 From: Gennadiy Civil Date: Thu, 21 Mar 2019 16:20:07 +0100 Subject: [PATCH 2/2] Update googletest/docs/advanced.md Co-Authored-By: antismap --- googletest/docs/advanced.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/googletest/docs/advanced.md b/googletest/docs/advanced.md index c2438dee..f8d9e27d 100644 --- a/googletest/docs/advanced.md +++ b/googletest/docs/advanced.md @@ -1396,7 +1396,7 @@ namespace: For more details, see the comments at the definitions of these functions. -NOTE: The `INSTANTIATE_TEST_SUITE_P` keyword is only valid since 1.8.1. For previous releases the keyword is `INSTANTIATE_TEST_CASE_P`. More generally, please refer to the documentation matching your release version. +NOTE: The `INSTANTIATE_TEST_SUITE_P` keyword is recommended (addressing http://go/gh/google/googletest/issues/1085) For 1.8.1 and previous releases the keyword is `INSTANTIATE_TEST_CASE_P`. which has been deprecated in favor of INSTANTIATE_TEST_SUITE_P. The following statement will instantiate tests from the `FooTest` test suite each with parameter values `"meeny"`, `"miny"`, and `"moe"`.