Fixes comments in sample7_unittest.cc.
This commit is contained in:
parent
fe25aea971
commit
b6c141fe2a
|
@ -45,12 +45,11 @@
|
||||||
using ::testing::TestWithParam;
|
using ::testing::TestWithParam;
|
||||||
using ::testing::Values;
|
using ::testing::Values;
|
||||||
|
|
||||||
// As a general rule, tested objects should not be reused between tests.
|
// As a general rule, to prevent a test from affecting the tests that come
|
||||||
// Also, their constructors and destructors of tested objects can have
|
// after it, you should create and destroy the tested objects for each test
|
||||||
// side effects. Thus you should create and destroy them for each test.
|
// instead of reusing them. In this sample we will define a simple factory
|
||||||
// In this sample we will define a simple factory function for PrimeTable
|
// function for PrimeTable objects. We will instantiate objects in test's
|
||||||
// objects. We will instantiate objects in test's SetUp() method and
|
// SetUp() method and delete them in TearDown() method.
|
||||||
// delete them in TearDown() method.
|
|
||||||
typedef PrimeTable* CreatePrimeTableFunc();
|
typedef PrimeTable* CreatePrimeTableFunc();
|
||||||
|
|
||||||
PrimeTable* CreateOnTheFlyPrimeTable() {
|
PrimeTable* CreateOnTheFlyPrimeTable() {
|
||||||
|
@ -62,11 +61,10 @@ PrimeTable* CreatePreCalculatedPrimeTable() {
|
||||||
return new PreCalculatedPrimeTable(max_precalculated);
|
return new PreCalculatedPrimeTable(max_precalculated);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Inside the test body, fixture constructor, SetUp(), and TearDown()
|
// Inside the test body, fixture constructor, SetUp(), and TearDown() you
|
||||||
// you can refer to the test parameter by GetParam().
|
// can refer to the test parameter by GetParam(). In this case, the test
|
||||||
// In this case, the test parameter is a PrimeTableFactory interface pointer
|
// parameter is a factory function which we call in fixture's SetUp() to
|
||||||
// which we use in fixture's SetUp() to create and store an instance of
|
// create and store an instance of PrimeTable.
|
||||||
// PrimeTable.
|
|
||||||
class PrimeTableTest : public TestWithParam<CreatePrimeTableFunc*> {
|
class PrimeTableTest : public TestWithParam<CreatePrimeTableFunc*> {
|
||||||
public:
|
public:
|
||||||
virtual ~PrimeTableTest() { delete table_; }
|
virtual ~PrimeTableTest() { delete table_; }
|
||||||
|
|
Loading…
Reference in New Issue
Block a user