eson/googletest
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

more comments changes

Browse Source
This commit is contained in:
Gennadiy Civil 2018-08-14 15:45:00 -04:00
parent 265efde9a5
commit bbf738a2c1
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
googlemock/src/gmock-spec-builders.cc
View File

@ -606,7 +606,7 @@ class MockObjectRegistry {
if (it->second.leakable) // The user said it's fine to leak this object. if (it->second.leakable) // The user said it's fine to leak this object.
continue; continue;
// TODO(wan@google.com): Print the type of the leaked object. // FIXME: Print the type of the leaked object.
// This can help the user identify the leaked object. // This can help the user identify the leaked object.
std::cout << "\n"; std::cout << "\n";
const MockObjectState& state = it->second; const MockObjectState& state = it->second;

2
googlemock/src/gmock.cc
View File

@ -33,7 +33,7 @@
namespace testing { namespace testing {
// TODO(wan@google.com): support using environment variables to // FIXME: support using environment variables to
// control the flag values, like what Google Test does. // control the flag values, like what Google Test does.
GMOCK_DEFINE_bool_(catch_leaked_mocks, true, GMOCK_DEFINE_bool_(catch_leaked_mocks, true,

2
googletest/test/googletest-options-test.cc
View File

@ -106,7 +106,7 @@ TEST(OutputFileHelpersTest, GetCurrentExecutableName) {
const bool success = exe_str == "app"; const bool success = exe_str == "app";
#else #else
// FIXME: remove the hard-coded "lt-" prefix when // FIXME: remove the hard-coded "lt-" prefix when
// Chandler Carruth's libtool replacement is ready. // libtool replacement is ready.
const bool success = const bool success =
exe_str == "googletest-options-test" || exe_str == "googletest-options-test" ||
exe_str == "gtest_all_test" || exe_str == "gtest_all_test" ||

2
googletest/test/gtest_repeat_test.cc
View File

@ -118,7 +118,7 @@ class MyParamTest : public testing::TestWithParam<int> {};
TEST_P(MyParamTest, ShouldPass) { TEST_P(MyParamTest, ShouldPass) {
// FIXME: Make parameter value checking robust // FIXME: Make parameter value checking robust
// WRT order of tests. // WRT order of tests.
GTEST_CHECK_INT_EQ_(g_param_test_count % kNumberOfParamTests, GetParam()); GTEST_CHECK_INT_EQ_(g_param_test_count % kNumberOfParamTests, GetParam());
g_param_test_count++; g_param_test_count++;
} }